Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolver): correct ttl from lru cache #1984

Merged
merged 5 commits into from Jul 30, 2023
Merged

fix(resolver): correct ttl from lru cache #1984

merged 5 commits into from Jul 30, 2023

Conversation

iberryful
Copy link
Contributor

@iberryful iberryful commented Jul 6, 2023 •
edited

This PR fixes #1751
Record ttl is calculated and corrected when getting from cache.

@djc djc requested a review from bluejekyll July 27, 2023 07:12
bluejekyll
bluejekyll approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think it’s valid for all resolver use cases, both in the server and in-memory.

thanks for putting this patch together. The logic appears correct.

crates/resolver/src/dns_lru.rs Show resolved Hide resolved
crates/resolver/src/dns_lru.rs Show resolved Hide resolved
@bluejekyll bluejekyll merged commit 9e64710 into hickory-dns:main Jul 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The TTL of the returned DNS query is always the result of the query to the superior
2 participants
@iberryful @bluejekyll