New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DnsHandle::send &self instead of &mut self #2018
Conversation
cc @djc |
wow, I'm amazed this required so few changes. This has probably been |
thank you @bluejekyll for the awesome project it's definetely help me a lot in building my project and hope i can contribute some too |
seems coverage is failing for some reason |
Coverage is for reference and to draw attention to areas where we might not have great coverage so we should take more care on the review. So don't worry about those. @djc, I'm ok with this change, though it will mean that with out this being mut, if for some reason we need it to be in the future, it will be a harder and bigger breaking change. I don't know whey that would be, but that is the only negative I see to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo one tiny nit.
Thanks for fixing that up -- and should have squashed this during merge, sorry for messing that up. |
following #1933
making the trait non mut so usage of it doesn't need Mutex