Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DnsHandle::send &self instead of &mut self #2018

Merged
merged 4 commits into from Sep 7, 2023

Conversation

ibigbug
Copy link
Contributor

@ibigbug ibigbug commented Sep 4, 2023

following #1933

making the trait non mut so usage of it doesn't need Mutex

@ibigbug
Copy link
Contributor Author

ibigbug commented Sep 4, 2023

cc @djc

@bluejekyll
Copy link
Member

wow, I'm amazed this required so few changes. This has probably been &mut since the first non-async implementations. This should definitely make the interface simpler for folks to use. I'll review in more detail once the tests are passing.

@ibigbug
Copy link
Contributor Author

ibigbug commented Sep 6, 2023

thank you @bluejekyll for the awesome project it's definetely help me a lot in building my project and hope i can contribute some too

@ibigbug
Copy link
Contributor Author

ibigbug commented Sep 6, 2023

seems coverage is failing for some reason

@bluejekyll
Copy link
Member

Coverage is for reference and to draw attention to areas where we might not have great coverage so we should take more care on the review. So don't worry about those.

@djc, I'm ok with this change, though it will mean that with out this being mut, if for some reason we need it to be in the future, it will be a harder and bigger breaking change. I don't know whey that would be, but that is the only negative I see to this.

@bluejekyll bluejekyll changed the title Make it no mut Make DnsHandle::send &self instead of &mut self Sep 6, 2023
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo one tiny nit.

crates/proto/src/xfer/dnssec_dns_handle.rs Outdated Show resolved Hide resolved
@djc djc merged commit 329c316 into hickory-dns:main Sep 7, 2023
15 of 18 checks passed
@djc
Copy link
Collaborator

djc commented Sep 7, 2023

Thanks for fixing that up -- and should have squashed this during merge, sorry for messing that up.

@ibigbug ibigbug deleted the make-it-no-mut branch September 7, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants