Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes caching bug when CNAME leads to negative response #2053

Merged
merged 1 commit into from Oct 7, 2023
Merged

Fixes caching bug when CNAME leads to negative response #2053

merged 1 commit into from Oct 7, 2023

Conversation

Clendenin
Copy link
Contributor

@bluejekyll
Copy link
Member

Thank you for this PR. I need to review this in a bit of detail. I want to make sure that this doesn’t accidentally skip retries of other Nameservers on failures.

bluejekyll
bluejekyll approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I took a look through, this indeed looks like the appropriate fix. Thanks for the PR and for tracking down this issue!

@bluejekyll bluejekyll merged commit 45bd92f into hickory-dns:main Oct 7, 2023
17 checks passed
@Clendenin
Copy link
Contributor Author

You're welcome, thanks for the speedy feedback! :)

@Clendenin Clendenin deleted the patch-cache branch October 7, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNAME TTL handling is broken when LookupIpStrategy::Ipv4AndIpv6 or LookupIpStrategy::Ipv6thenIpv4
2 participants
@Clendenin @bluejekyll