-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 0.24 release with branding change to Hickory DNS #2054
Conversation
@djc, I think this is ready, final release of trust-dns :( I've tried to @ mention all the new names everywhere that I can. |
I put some feedback on the high-level plan in #2501. |
8b95237
to
d258435
Compare
This won't be merged until after the repo is moved. I also need to update all brand names. |
b92d6cd
to
05a73d4
Compare
Ok, I think this is ready @djc. Open questions to resolve are basically on the names, essentially all the
Pros for with the What do you think? |
I like the For the crate names, are you going with hickory-dns-* or hickory-*? The shorter names are nice but also feel slightly inconsistent if the project name does include the DNS suffix. Not sure if that's a big issue. |
Fair, I anticipated some open discussion on this, so registered both variants. I think your reasoning is good here.
Crate names are currently as follows:
Personally, I like the shorter names, again, I registered both because I initially thought we might do |
Ok, I can't think of anything missing right now, I think everything is taken care of. Once this is approved, I will first merge in the 0.23.1 branch, and release that, then move the repo. Then merge this branch, and do a release on the hickory crates. assuming I got everything right that will just work. That could be delayed if I need to update any repo integration configs, etc. After that, over the weekend I can do things like properly wiring up the domain names, etc. |
oh, it looks like you approved, @djc, let me know if you have any concerns with the plan I mentioned above. I'll start that later today. |
7bf13bf
to
0666b9e
Compare
See #2051