Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.24 release with branding change to Hickory DNS #2054

Merged
merged 30 commits into from
Oct 14, 2023

Conversation

bluejekyll
Copy link
Member

@bluejekyll bluejekyll commented Oct 7, 2023

See #2051

@bluejekyll bluejekyll changed the title update all READMEs with notices about the name change Prepare final 0.24 release with branding change Oct 7, 2023
@bluejekyll bluejekyll marked this pull request as ready for review October 8, 2023 00:22
@bluejekyll
Copy link
Member Author

@djc, I think this is ready, final release of trust-dns :(

I've tried to @ mention all the new names everywhere that I can.

@bluejekyll bluejekyll requested a review from djc October 8, 2023 00:23
@djc
Copy link
Collaborator

djc commented Oct 9, 2023

I put some feedback on the high-level plan in #2501.

@bluejekyll bluejekyll changed the title Prepare final 0.24 release with branding change Prepare 0.24 release with branding change Oct 9, 2023
@bluejekyll bluejekyll changed the title Prepare 0.24 release with branding change Prepare 0.24 release with branding change to Hickory DNS Oct 9, 2023
@bluejekyll
Copy link
Member Author

This won't be merged until after the repo is moved. I also need to update all brand names.

@bluejekyll bluejekyll mentioned this pull request Oct 9, 2023
8 tasks
@bluejekyll bluejekyll marked this pull request as draft October 10, 2023 00:52
Cargo.toml Outdated Show resolved Hide resolved
@bluejekyll bluejekyll marked this pull request as ready for review October 13, 2023 02:45
@bluejekyll
Copy link
Member Author

Ok, I think this is ready @djc.

Open questions to resolve are basically on the names, essentially all the - or no - separators. I think for all the crates we should keep the - in the crate name. Now for the rest, should we setting on using - in the Organization and the Project, or no -? I think you want consistency. What's in this change now is this:

https://github.com/hickorydns/hickory-dns and hickorydns.org. I like the idea of being consistent, So I think the options are:

  • https://github.com/hickory-dns/hickory-dns and hickory-dns.org or
  • https://github.com/hickorydns/hickorydns and hickorydns.org

Pros for with the -, it will be more consistent with crate names, cons, it's not as "pretty" and may be less discoverable... But for that, we can just use redirects, or something.

What do you think?

@djc
Copy link
Collaborator

djc commented Oct 13, 2023

https://github.com/hickorydns/hickory-dns and hickorydns.org. I like the idea of being consistent, So I think the options are:

* `https://github.com/hickory-dns/hickory-dns` and `hickory-dns.org` or
* `https://github.com/hickorydns/hickorydns` and `hickorydns.org`

Pros for with the -, it will be more consistent with crate names, cons, it's not as "pretty" and may be less discoverable... But for that, we can just use redirects, or something.

What do you think?

I like the - -- I find it more readable to have the words visually separated. It works with capitalization (HickoryDNS) but all lowercase (as in domain names or crate names) it's not as nice. So I would just call it Hickory-DNS and hickory-dns.

For the crate names, are you going with hickory-dns-* or hickory-*? The shorter names are nice but also feel slightly inconsistent if the project name does include the DNS suffix. Not sure if that's a big issue.

CHANGELOG.md Outdated Show resolved Hide resolved
@bluejekyll
Copy link
Member Author

I like the - -- I find it more readable to have the words visually separated. It works with capitalization (HickoryDNS) but all lowercase (as in domain names or crate names) it's not as nice. So I would just call it Hickory-DNS and hickory-dns.

Fair, I anticipated some open discussion on this, so registered both variants. I think your reasoning is good here.

For the crate names, are you going with hickory-dns-* or hickory-*? The shorter names are nice but also feel slightly inconsistent if the project name does include the DNS suffix. Not sure if that's a big issue.

Crate names are currently as follows:

  • trust-dns-proto -> hickory-proto
  • trust-dns-resolver -> hickory-resolver
  • trust-dns-recursor -> hickory-recursor
  • trust-dns-server -> hickory-server
  • trust-dns-client -> hickory-client
  • trust-dns -> hickory-dns

Personally, I like the shorter names, again, I registered both because I initially thought we might do hickory-dns-* for everything.

@bluejekyll
Copy link
Member Author

Ok, I can't think of anything missing right now, I think everything is taken care of. Once this is approved, I will first merge in the 0.23.1 branch, and release that, then move the repo. Then merge this branch, and do a release on the hickory crates. assuming I got everything right that will just work. That could be delayed if I need to update any repo integration configs, etc. After that, over the weekend I can do things like properly wiring up the domain names, etc.

@bluejekyll
Copy link
Member Author

oh, it looks like you approved, @djc, let me know if you have any concerns with the plan I mentioned above. I'll start that later today.

@bluejekyll bluejekyll merged commit 408d0ba into main Oct 14, 2023
17 checks passed
@bluejekyll bluejekyll deleted the prepare-final-trust-dns-0.24 branch October 14, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants