recursor: strip dnssec records on cache hit #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japaric
commented
Jun 17, 2024
conformance/packages/conformance-tests/src/resolver/dnssec/rfc4035/section_3/section_3_2.rs
Show resolved
Hide resolved
djc
approved these changes
Jun 18, 2024
japaric
force-pushed
the
ja-recursor-strip-dnssec-records-on-cache-hit
branch
from
d8e6890
to
5221f16
Compare
|
can we merge this? my next PR (for #2234) would be cleaner with this change in place |
|
I'd like to get a review from @bluejekyll in. You can use this branch as the base branch for your next one? |
This was referenced Jun 20, 2024
after PR #2239 we store both answers and rrsig records in the same cache so there's no reason to branch here anymore if the recursor is not security aware then rrsigs will never make it into record_cache
japaric
force-pushed
the
ja-recursor-strip-dnssec-records-on-cache-hit
branch
from
5221f16
to
ecf3622
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is triggered by a DO=1 query followed by the almost exact same query but with DO=0
this is best reviewed on a commit by commit basis