Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ipv4 early return/search #467

Merged
merged 3 commits into from
May 17, 2018
Merged

fix for ipv4 early return/search #467

merged 3 commits into from
May 17, 2018

Conversation

bluejekyll
Copy link
Member

@bluejekyll bluejekyll commented May 15, 2018

If ndots is greater than for, then this skips the early return of the IP address, and delays that until the final result after performing all other queries.

fixes: #431

@bluejekyll
Copy link
Member Author

@briansmith, you filed this original issue. Let me know if you see any issues with this patch to resolve it.

I still need to add a testcase for this logic, so it's not ready to merge yet.

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

Merging #467 into master will increase coverage by 0.05%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
+ Coverage   86.51%   86.57%   +0.05%     
==========================================
  Files         133      133              
  Lines       13429    13496      +67     
==========================================
+ Hits        11618    11684      +66     
- Misses       1811     1812       +1
Impacted Files Coverage Δ
resolver/src/lookup_ip.rs 90.22% <83.33%> (-0.1%) ⬇️
resolver/src/resolver_future.rs 76.92% <98.52%> (+3.88%) ⬆️
proto/src/tcp/tcp_client_stream.rs 92.4% <0%> (-1.27%) ⬇️
proto/src/rr/domain/label.rs 92.47% <0%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8494532...a665eeb. Read the comment docs.

@bluejekyll bluejekyll changed the title proposed fix for ipv4 early return/search fix for ipv4 early return/search May 17, 2018
@bluejekyll bluejekyll merged commit d1731f6 into master May 17, 2018
@bluejekyll bluejekyll deleted the fix-ipv4-search branch May 20, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names like "1.2.3.4" are wrongly assumed to be IP addresses
1 participant