Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix max query depth tracking #469

Merged
merged 1 commit into from
May 16, 2018
Merged

fix max query depth tracking #469

merged 1 commit into from
May 16, 2018

Conversation

bluejekyll
Copy link
Member

The original patch to this issue was incorrect.
This better, it relies on the task cleanup to remove the QUERY_DEPTH, thus we only need to track the increments.

also fixes the global resolver example to fail if the tests fail.

@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #469 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   86.53%   86.51%   -0.03%     
==========================================
  Files         133      133              
  Lines       13428    13429       +1     
==========================================
- Hits        11620    11618       -2     
- Misses       1808     1811       +3
Impacted Files Coverage Δ
resolver/src/lookup_state.rs 92.64% <100%> (+0.01%) ⬆️
proto/src/multicast/mdns_stream.rs 79.88% <0%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f22e5a...088b87f. Read the comment docs.

@bluejekyll bluejekyll merged commit 8494532 into master May 16, 2018
@bluejekyll bluejekyll changed the title fix max query deptch tracking fix max query depth tracking May 18, 2018
@bluejekyll bluejekyll deleted the fix-max-depth branch May 20, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant