Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old client to future #87

Merged
merged 5 commits into from Jan 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 17 additions & 1 deletion CHANGELOG.md
Expand Up @@ -2,7 +2,23 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## 0.9.4 (in progress)
## 0.10.0 (in progress)
### Changed
- *Important* Possible breaking API change, the original Client has been renamed
In an attempt to reduce the overhead of managing the project. The original
Client has now been revamped to essentially be a synchronous Client over the
ClientFuture implementation. The ClientFuture has proven to be a more stable
and reliable implementation. It was attempted to make the move seamless,
but two new types were introduced, `SyncClient` and `SecureSyncClient`, which
are both synchronous implementations of the old Client function interfaces.
Please read those docs on those new types and the Client trait.

### Removed
- *Important* The original Server implementation was removed entirely. Please
use the ServerFuture implementation from now on. Sorry for the inconvenience,
but this is necessary to make sure that the software remains at a high quality
and there is no easy way to migrate the original Server to use ServerFuture.

### Added
- support for ECDSAP256SHA256, ECDSAP384SHA384 and ED25519 (client and server)
- additional config options for keys to named, see `tests/named_test_configs/example.toml`
Expand Down
41 changes: 0 additions & 41 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions README.md
Expand Up @@ -218,17 +218,6 @@ It is a default feature, so default-features will need to be set to false (this
trust-dns = { version = "*", default-features = false, features = ["openssl"] }
```

- mio_client

Also a default feature, this exables the old deprecated MIO based client. This will remove an independent dependency requirement on the MIO library (there is an implicit dependency on MIO via the tokio-rs library, that will not be removed). Disabling this feature will only compile in the futures-rs based client. The below example line will disable all default features and enable mio_client, remove `"mio_client"` to remove the direct dependency on MIO.

```
[dependencies]
...
trust-dns = { version = "*", default-features = false, features = ["mio_client"] }
```


# FAQ

- Why are you building another DNS server?
Expand Down
5 changes: 1 addition & 4 deletions client/Cargo.toml
Expand Up @@ -37,8 +37,7 @@ license = "MIT/Apache-2.0"
build = "build.rs"

[features]
default = ["openssl", "mio_client", "ring"]
mio_client = ["mio"]
default = ["openssl", "ring"]

[lib]
name = "trust_dns"
Expand All @@ -52,10 +51,8 @@ error-chain = "0.1.12"
futures = "^0.1.6"
lazy_static = "^0.2.1"
log = "^0.3.5"
mio = { version = "^0.5.1", optional = true }
openssl = { version = "^0.9.5", optional = true }
rand = "^0.3"
# ring = { version = "^0.6", optional = true, features = ["rsa_signing"] }
ring = { version = "^0.6", optional = true }
rustc-serialize = "^0.3.18"
time = "^0.1"
Expand Down