Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolver methods for SOA and NS records #890

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

rotty
Copy link
Contributor

@rotty rotty commented Oct 17, 2019

These are useful if you want to use the resolver to retrieve:

  • The domain master address, to know where to send DNS UPDATE
    messages to.
  • The authoritative nameservers for a domain, to monitor them for the
    propagation of an update.

@blujekyll: I know you are busy on PR #849, so don't feel obliged to
handle my PRs; I can rebase them when #849 has landed.

@bluejekyll
Copy link
Member

thanks, I should be merging that soon!

These are useful if you want to use the resolver to retrieve:

- The domain master address, to know where to send DNS UPDATE
  messages to.
- The authoritative nameservers for a domain, to monitor them for the
  propagation of an update.
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0bfabbd). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #890   +/-   ##
=========================================
  Coverage          ?   86.61%           
=========================================
  Files             ?      162           
  Lines             ?    16989           
  Branches          ?        0           
=========================================
  Hits              ?    14715           
  Misses            ?     2274           
  Partials          ?        0

Copy link
Member

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though this raises an a question in my mind.

What should our general practice be for the less often used record types? There is a generic lookup method, I'm just trying to figure out the best practice here.

@bluejekyll bluejekyll merged commit 10541a1 into hickory-dns:master Oct 18, 2019
@rotty
Copy link
Contributor Author

rotty commented Oct 18, 2019

I'm not sure where to draw the line either, it seems to be overkill to include methods for all record types. My gut feeling is that (glancing over https://en.wikipedia.org/wiki/List_of_DNS_record_types), the most common record types are covered now.

Some additional use-cases that seem plausible: When someone implements an SSH client, SSHFP lookup would be relevant, an email application may want OPENPGPKEY lookups and TLS clients may want to do TLSA lookups. I have no idea how commonly these are actually deployed.

@bluejekyll
Copy link
Member

But for the less common types, they could use the generic lookup method, right? If we really want a function per lookup type, we could just expand the macro to be all types and be done with it... just seems like overkill.

@rotty
Copy link
Contributor Author

rotty commented Oct 19, 2019

Sure, the generic lookup would have sufficed for my purposes as well, it just seemed like NS and SOA lookups are one the same level of "commonality" as MX and SRV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants