Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failure dependency, only expose std::error impls #988

Merged
merged 1 commit into from
Jan 12, 2020

Conversation

bluejekyll
Copy link
Member

FYI, @chunyingw

@bluejekyll bluejekyll force-pushed the clean-up-api branch 2 times, most recently from 0a9ec23 to 700ca75 Compare January 12, 2020 00:51
@bluejekyll bluejekyll changed the title Clean up API Remove failure dependency, only expose std::error impls Jan 12, 2020
@bluejekyll bluejekyll force-pushed the clean-up-api branch 3 times, most recently from 788acdc to 62540fa Compare January 12, 2020 02:08
@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #988 into master will decrease coverage by 0.38%.
The diff coverage is 23.15%.

@@            Coverage Diff            @@
##           master    #988      +/-   ##
=========================================
- Coverage   85.88%   85.5%   -0.38%     
=========================================
  Files         122     120       -2     
  Lines       13289   13329      +40     
=========================================
- Hits        11412   11396      -16     
- Misses       1877    1933      +56

@bluejekyll bluejekyll merged commit c10c3a5 into master Jan 12, 2020
@bluejekyll bluejekyll deleted the clean-up-api branch January 12, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant