Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drew.new up: Fixes runtime problems, adds ranked choice voting #72

Merged
merged 18 commits into from Jul 14, 2019
Merged

Drew.new up: Fixes runtime problems, adds ranked choice voting #72

merged 18 commits into from Jul 14, 2019

Conversation

drewstone
Copy link
Collaborator

No description provided.

@drewstone drewstone changed the title Drew.new up: Fixes the runtime problems Drew.new up: Fixes runtime problems, adds ranked choice voting Jul 1, 2019
@drewstone drewstone requested a review from jnaviask July 1, 2019 23:03
jnaviask
jnaviask reviewed Jul 2, 2019
View reviewed changes
Copy link
Collaborator

@jnaviask jnaviask left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two comments and also I can't seem to make a balance transactions via the CLI -- any ideas? We'll also need to update node types for the voting change.

modules/edge-voting/src/voting.rs Outdated Show resolved Hide resolved
setup.sh Outdated Show resolved Hide resolved
@drewstone drewstone added enhancement New feature or request ready The pull request is ready for review labels Jul 3, 2019
jnaviask
jnaviask approved these changes Jul 12, 2019
View reviewed changes
Copy link
Collaborator

@jnaviask jnaviask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides some small docs changes!

README.md Outdated Show resolved Hide resolved
@drewstone drewstone merged commit 706407e into master Jul 14, 2019
@drewstone drewstone deleted the drew.new_up branch July 14, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnaviask jnaviask jnaviask approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready The pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewstone @jnaviask