Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Add mssql to supported flavours array for WITH clause (#258) #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GiorgioAresu
Copy link

Add WITH clause support to mssql flavor.

Gonna make another PR for docs

@GiorgioAresu GiorgioAresu changed the title Fix #258 Add mssql to supported flavours array for WITH clause (#258) Jul 26, 2016
@hiddentao
Copy link
Owner

Is the WithBlock exactly the same code for both postgres and mssql? If so then I think it would be better to refactor it out into a separate file and then include that into the gulp build process.

@GiorgioAresu
Copy link
Author

Yep, the issue I saw was that the with clause is not supported in mysql so
I couldn't put it in the common file. I was in a rush, will take a look and
try to do it better

On Wed, Jul 27, 2016, 19:16 Ramesh Nair notifications@github.com wrote:

Is the WithBlock exactly the same code for both postgres and mssql? If so
then I think it would be better to refactor it out into a separate file and
then include that into the gulp build process.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#259 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACxC6Syefrbxa-SbP2sPJzGpmOQzlzhDks5qZ5J9gaJpZM4JVmJM
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants