Fixes #1
Merged
Fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stuffing mutable data into the controller instance is going to cause massive lossage, as in a pre-fork environment (i.e. any non-test env) then you're likely to have different processes get subsequent requests - meaning that requests will see each-other's tokens, and so break. Instead, pass the ctx into the controller methods as a parameter, as this means we keep all the state in the context where it should be, which makes this work correctly
hidek
pushed a commit
that referenced
this pull request
Aug 9, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya.
I've made some fixes to this module, I'd be most grateful if you could review them and give me some feedback (or release a new version if you're happy with them).