Drop the Algorithm requirement on JWK for direct #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Algorithm parameter on the JWK should be the algorithm used in the key (e.g. A256GCM). In Direct, the key is used as the Content Encryption key, and not as a Wrapping key, which means that the Algorithm on the key should be A256GCM.
puiterwijk
added a commit
to fedora-iot/clevis-pin-tpm2
that referenced
this pull request
Dec 8, 2021
Right now, this must be Dir in order to not crash, but after [1] gets merged, it will have to be A256GCM. Since we know the algorithm, let's just ignore it. [1]: hidekatsu-izuno/josekit-rs#12 Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
|
I don't think your suggestion is appropriate. The DirectJweAlgorithm is intended for "Direct Encryption with a Shared Symmetric Key" (RFC7518 4.5). The alg parameter will always be "dir". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Algorithm parameter on the JWK should be the algorithm used in the
key (e.g. A256GCM).
In Direct, the key is used as the Content Encryption key, and not as a
Wrapping key, which means that the Algorithm on the key should be
A256GCM.