Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamo] non-linear operator support + tests #143

Merged
merged 21 commits into from Mar 24, 2023
Merged

[Dynamo] non-linear operator support + tests #143

merged 21 commits into from Mar 24, 2023

Conversation

AndreSlavescu
Copy link
Contributor

[Dynamo] non-linear operator support + tests

  • Non-linear operator support from torch.nn.functional and torch.nn

features

  • added abs operator in fp32 and fp64 (cpu + cuda)
  • tests for each torch.nn.functional and torch.nn operator

AndreSlavescu and others added 17 commits January 24, 2023 12:03
@AndreSlavescu
assertion message for IR check
f52ae28
@AndreSlavescu
assertion message for valid IR check
82afa1a
@AndreSlavescu
fixed lint
8cd661c
@AndreSlavescu
sigmoid and hardsigmoid module support
a7db719
@AndreSlavescu
Merge branch 'docs' of https://github.com/AndreSlavescu/hidet into docs
4fda6f5
@AndreSlavescu
Merge branch 'main' of https://github.com/hidet-org/hidet into docs
61ecba3
@AndreSlavescu
Merge branch 'main' of https://github.com/AndreSlavescu/hidet into docs
03e6250
@AndreSlavescu
Sigmoid/Hardsigmoid Modules
bae449d
@AndreSlavescu
extended module/function support
4c9c78f
@AndreSlavescu
reformat
923457b
@AndreSlavescu
register_functions typo fix + normalization tests
88c1a87
@AndreSlavescu
tests + refactoring
28c4960
@AndreSlavescu
removed group norm
c414ffa
@AndreSlavescu
batch_norm bug fix
3ca4c14
@AndreSlavescu
non-linear operators
7fcec9f
@AndreSlavescu
non-linear activation operators
79d086a
@AndreSlavescu
Merge pull request #7 from AndreSlavescu/operators
1c48549 
[Dynamo] non-linear activation operator support
yaoyaoding
yaoyaoding requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@yaoyaoding yaoyaoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndreSlavescu! It generally looks good. I left some suggestions on the minor issues.

python/hidet/graph/ops/definitions/activation.py Outdated Show resolved Hide resolved
python/hidet/ir/primitives/math.py Outdated Show resolved Hide resolved
tests/operators/test_activation.py Outdated Show resolved Hide resolved
tests/operators/test_activation.py Outdated Show resolved Hide resolved
python/hidet/graph/ops/definitions/activation.py Outdated Show resolved Hide resolved
python/hidet/graph/ops/definitions/activation.py Outdated Show resolved Hide resolved
python/hidet/graph/ops/definitions/activation.py Outdated Show resolved Hide resolved
python/hidet/graph/ops/definitions/activation.py Outdated Show resolved Hide resolved
python/hidet/graph/ops/definitions/activation.py Outdated Show resolved Hide resolved
yaoyaoding
yaoyaoding approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@yaoyaoding yaoyaoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AndreSlavescu.

@yaoyaoding yaoyaoding merged commit 01d4b93 into hidet-org:main Mar 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaoyaoding yaoyaoding yaoyaoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndreSlavescu @yaoyaoding