[Operators] Improving fp32 matrix multiplication on x86 CPUs #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @BolinSNLHM, Thanks a lot for the contribution! I will review it soon. Before that, could you spend some time on benchmark on the new implementation vs. baselines (e.g., pytorch and tvm). |
|
The preliminary performance results of the improved version of the matmul operator: (The results for the 1x1024x1024, as the bars are too low to be visible: |
yaoyaoding
reviewed
Dec 11, 2023
python/mat_new.py
Outdated
| @@ -0,0 +1,148 @@ | |||
| import numpy as np | |||
| @@ -64,7 +66,7 @@ def __init__(self, a: TensorNode, b: TensorNode): | |||
| ) | |||
|
|
|||
| super().__init__( | |||
| name='matmul_f32_x86', | |||
| name='matmul_f32_x86_v2', | |||
There was a problem hiding this comment.
Maybe still use matmul_f32_x86?
deleted redundant file
use the original name
|
Thanks @BolinSNLHM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.