Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Option] Add option to set class Var id attribute to 0 by default #393

Merged
merged 4 commits into from Dec 15, 2023
Merged

[Option] Add option to set class Var id attribute to 0 by default #393

merged 4 commits into from Dec 15, 2023

Conversation

destefy
Copy link
Contributor

@destefy destefy commented Dec 14, 2023

By default Var instances will have an id of 0.

This is to ensure that each entire FlowGraph is entirely deterministic given the same interpreter+input.

yaoyaoding
yaoyaoding reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@yaoyaoding yaoyaoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @destefy!
Left two minor suggestions.

python/hidet/ir/expr.py Outdated Show resolved Hide resolved
python/hidet/option.py Outdated Show resolved Hide resolved
@yaoyaoding
Copy link
Member

Thanks @destefy!

@yaoyaoding yaoyaoding merged commit e7f2efd into hidet-org:main Dec 15, 2023
2 checks passed
@destefy destefy deleted the var_id branch December 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaoyaoding yaoyaoding yaoyaoding left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@destefy @yaoyaoding