Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

Add OAuth driver #2

Merged
merged 18 commits into from Nov 22, 2017
Merged

Add OAuth driver #2

merged 18 commits into from Nov 22, 2017

Conversation

hiendv
Copy link
Owner

@hiendv hiendv commented Nov 20, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 94.609% when pulling bc03573 on add-oauth into b09d184 on master.

@hiendv
Copy link
Owner Author

hiendv commented Nov 20, 2017

Interesting

# github.com/hiendv/gate/oauth
/tmp/go-build957966995/github.com/hiendv/gate/oauth/_test/_obj_test/oauth.go:51: cannot use DefaultProvider literal (type DefaultProvider) as type Provider in argument to driver.setProvider:
	DefaultProvider does not implement Provider (wrong type for Exchange method)
		have Exchange("github.com/hiendv/gate/vendor/golang.org/x/net/context".Context, string) (*oauth2.Token, error)
		want Exchange("context".Context, string) (*oauth2.Token, error)
FAIL	github.com/hiendv/gate/oauth [build failed]

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.9%) to 93.103% when pulling ca724ca on add-oauth into b09d184 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 20, 2017

Coverage Status

Coverage decreased (-6.9%) to 93.103% when pulling ca724ca on add-oauth into b09d184 on master.

@coveralls
Copy link

coveralls commented Nov 20, 2017

Coverage Status

Coverage decreased (-6.8%) to 93.158% when pulling 967fd4f on add-oauth into b09d184 on master.

@coveralls
Copy link

coveralls commented Nov 20, 2017

Coverage Status

Coverage decreased (-6.8%) to 93.158% when pulling f0fbe65 on add-oauth into b09d184 on master.

@coveralls
Copy link

coveralls commented Nov 20, 2017

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling 2c397a5 on add-oauth into b09d184 on master.

@hiendv
Copy link
Owner Author

hiendv commented Nov 20, 2017

Documentation and examples are required before merging.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling bd70743 on add-oauth into b09d184 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling bd70743 on add-oauth into b09d184 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling bd70743 on add-oauth into b09d184 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling c75c837 on add-oauth into b09d184 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling c75c837 on add-oauth into b09d184 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 97.135% when pulling c75c837 on add-oauth into b09d184 on master.

@hiendv hiendv merged commit ab9ae3d into master Nov 22, 2017
@hiendv hiendv deleted the add-oauth branch November 22, 2017 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants