Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dart class models instead using dynamic types and Maps #180

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Implement dart class models instead using dynamic types and Maps #180

merged 3 commits into from
Dec 21, 2022

Conversation

icodelifee
Copy link
Contributor

@icodelifee icodelifee commented Sep 26, 2022

This is a breaking change that introduces Dart Class models to this package.
Using dynamic types are prone to bug and its easier to use Dart class models instead of Maps

I have done my best to refactor the required changes for this feature.
There aren't changes internally that would change the behavior of this package.

Please let me know if there are any changes required.
Thanks

@AAkira
Copy link
Contributor

AAkira commented Oct 4, 2022

Thanks!! @icodelifee
I've always wanted to make the same change.

@JulianBissekkou
Copy link

Great PR, can we get this merged @hiennguyen92 ?

@stefanschaller
Copy link

Would love to see this in the next version. @hiennguyen92

@booooohdan
Copy link

@hiennguyen92 please, do something or grant access to another contributor if you don't work on this package

@ozalisky
Copy link

@hiennguyen92 please, do something or grant access to another contributor if you don't work on this package

You always can fork the package and work on it yourself. What's the point to spam here?

@hiennguyen92 hiennguyen92 merged commit 0f03888 into hiennguyen92:master Dec 21, 2022
@hiennguyen92
Copy link
Owner

thanks you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants