Add proxy support for SocketClient/SSHClient #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also interested interested in this patch. |
hierynomus
added a commit
that referenced
this pull request
Jan 9, 2015
Add proxy support for SocketClient/SSHClient
|
Seems simple enough, merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple PR to add java.net.Proxy support to SocketClient. It's in "works for me" status, tested against a SOCKS proxy.
I'm not sure if you want the added repetition on the connect() methods or not. I just followed the way things were already laid out.
This -might- resolve #10 as well, but I don't have an available HTTP proxy to test.