Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osgi problem #300

Closed
andreaturli opened this issue Feb 3, 2017 · 19 comments · Fixed by #301
Closed

osgi problem #300

andreaturli opened this issue Feb 3, 2017 · 19 comments · Fixed by #301

Comments

@andreaturli
Copy link
Contributor

Apache jclouds project happily relies on your project, thanks! Unfortunately a downstream project, jclouds-karaf wants to use your lib in an OSGi container but when we install the following bundle:

install -s mvn:com.hierynomus/sshj/0.12.0

we've noticed that

karaf@root()> capabilities 113
com.hierynomus.sshj [113] provides:
-----------------------------------
osgi.wiring.bundle; com.hierynomus.sshj 0.12.0 [UNUSED]
osgi.wiring.host; com.hierynomus.sshj 0.12.0 [UNUSED]
osgi.identity; com.hierynomus.sshj 0.12.0 [UNUSED]
osgi.wiring.package; net.schmizz.concurrent 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.keepalive 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.common 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel.direct 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel.forwarded 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.sftp 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.signature 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.cipher 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.compression 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.digest 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.kex 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.mac 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.random 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.verification 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.keyprovider 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.method 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.password 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.xfer 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.xfer.scp 0.0.0 [UNUSED]

which basically means that the wiring packages are unversioned.

This may be a gradle issue build.gradle as per this SO @discussion.

Thanks for your support.
@hierynomus
Copy link
Owner

Have you tried upgrading to 0.19.1? There were indeed OSGi problems, but thanks to two very helpful contributors @15knots, @adagios, these should have been sorted out.

@andreaturli
Copy link
Contributor Author

thanks @hierynomus looking at #255 it seems that 0.19.1 may not be enough as it has been merged after the 0.19.1 release?

@hierynomus
Copy link
Owner

Ahh you're right!

You might want to try to build it from master, and see whether this fixes the problem you're seeing, else I can fix it before releasing :)

@andreaturli
Copy link
Contributor Author

I've built sshj locally and installed the bundle manually

karaf@root()> bundle:install -s file:///Users/andrea/git/andreaturli/sshj/build/libs/sshj-0.19.2-dev.23+65b3003.jar
Bundle ID: 119
karaf@root()> capabilities 119
capabilities 119
com.hierynomus.sshj [119] provides:
-----------------------------------
osgi.wiring.bundle; com.hierynomus.sshj 0.19.2.dev_23_65b3003 [UNUSED]
osgi.wiring.host; com.hierynomus.sshj 0.19.2.dev_23_65b3003 [UNUSED]
osgi.identity; com.hierynomus.sshj 0.19.2.dev_23_65b3003 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.backport 0.0.0 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.secg 0.0.0 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.signature 0.0.0 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.transport 0.0.0 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.transport.cipher 0.0.0 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.transport.kex 0.0.0 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.userauth.keyprovider 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.concurrent 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.keepalive 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.common 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel.direct 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel.forwarded 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.sftp 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.signature 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.cipher 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.compression 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.digest 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.kex 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.mac 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.random 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.verification 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.keyprovider 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.method 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.password 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.xfer 0.0.0 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.xfer.scp 0.0.0 [UNUSED]

still no luck for me

@adagios
Copy link
Contributor

adagios commented Feb 3, 2017

I'll have a go at it, I think it should be easy to change the build.gradle

@andreaturli
Copy link
Contributor Author

Thx @adagios, see if my link to SO is helpful.

@adagios adagios mentioned this issue Feb 3, 2017
Merged
@adagios
Copy link
Contributor

adagios commented Feb 3, 2017

@andreaturli could you test it? I didn't have a chance. Just looked at the generated MANIFEST and it seemed ok.

@andreaturli
Copy link
Contributor Author

I will ASAP @adagios, and I'll let you guys know. thanks!

@andreaturli
Copy link
Contributor Author 

karaf@root()> bundle:install -s file:///Users/andrea/git/andreaturli/sshj/build/libs/sshj-0.19.2-dev.24+edfb069.jar
Bundle ID: 120
karaf@root()> capabilities 120
com.hierynomus.sshj [120] provides:
-----------------------------------
osgi.wiring.bundle; com.hierynomus.sshj 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.host; com.hierynomus.sshj 0.19.2.dev_24_edfb069 [UNUSED]
osgi.identity; com.hierynomus.sshj 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.backport 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.secg 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.signature 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.transport 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.transport.cipher 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.transport.kex 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; com.hierynomus.sshj.userauth.keyprovider 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.concurrent 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.keepalive 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.common 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel.direct 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.connection.channel.forwarded 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.sftp 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.signature 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.cipher 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.compression 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.digest 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.kex 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.mac 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.random 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.transport.verification 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.keyprovider 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.method 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.userauth.password 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.xfer 0.19.2.dev_24_edfb069 [UNUSED]
osgi.wiring.package; net.schmizz.sshj.xfer.scp 0.19.2.dev_24_edfb069 [UNUSED]

much better! Please ship it!

@hierynomus
Copy link
Owner

Thanks @andreaturli @adagios.

Build is running currently

@andreaturli
Copy link
Contributor Author

please let me know when it is available (or an endpoint that I can look at by myself) so that I can test the new release (presumably 0.9.2, right?)

@hierynomus
Copy link
Owner

New release will indeed be 0.19.2. I will release it later this week.

@andreaturli
Copy link
Contributor Author

awesome, thanks!

@andreaturli
Copy link
Contributor Author

hi guys, gentle nudge, any update on the 0.9.2 release? Thanks!

@hierynomus
Copy link
Owner

You're right :) I'm updating the release notes now and will release a 0.20.0 afterwards.
I've added some new kex algorithms, that's why a new minor instead of patch version.

@andreaturli
Copy link
Contributor Author

thx @hierynomus I really appreciate your help, looking forward to use the new version, whatever it is :P

slightly off-topic: would it be interesting for sshj to support an AuthMethod for ssh-agent?

@hierynomus
Copy link
Owner

I'm always open to exploring new features if they're useful to the community :)

@hierynomus
Copy link
Owner

Should be published now and appearing in Maven Central soon!

@andreaturli
Copy link
Contributor Author

Thanks @hierynomus, really appreciated. Updating jclouds/jclouds project to use sshj:0.20.0

@andreaturli andreaturli mentioned this issue Feb 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds current version to exported classes adagios/sshj
3 participants
@adagios @hierynomus @andreaturli