Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle server initiated global requests #472

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

pepijnve
Copy link
Contributor

RFC 4254 section 4 states that either side of the connection
may send global requests at any time and that the receiver
MUST respond appropriately.

This PR replaces the default logic of responding with 'UNIMPLEMENTED'
with the correct 'MSG_REQUEST_FAILURE' if 'wantReply' is set.

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #472 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #472      +/-   ##
============================================
- Coverage     55.92%   55.84%   -0.08%     
- Complexity     1215     1216       +1     
============================================
  Files           192      192              
  Lines          7859     7870      +11     
  Branches        714      715       +1     
============================================
  Hits           4395     4395              
- Misses         3112     3123      +11     
  Partials        352      352
Impacted Files Coverage Δ Complexity Δ
...va/net/schmizz/sshj/connection/ConnectionImpl.java 58.06% <0%> (-5.66%) 20 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c09eb...b4345a6. Read the comment docs.

@hierynomus hierynomus merged commit b0dee02 into hierynomus:master Nov 26, 2018
@hierynomus
Copy link
Owner

Thanks @pepijnve!

@pepijnve
Copy link
Contributor Author

Context for this change is that I kept seeing Sending SSH_MSG_UNIMPLEMENTED debug messages scroll by which led me to wonder what wasn't implemented exactly.
Turns out on of the servers I was connected to was sending keep-alive@openssh.com global requests periodically. After this change those get handled silently.

@pepijnve pepijnve deleted the server_global_requests branch November 26, 2018 14:22
@hierynomus
Copy link
Owner

Thanks for the background info!

Repository owner deleted a comment Nov 26, 2018
Repository owner deleted a comment Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants