Added detekt into the project #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great work, Kar! Thank you so much for pointing out the fail of detekt. I think just make sure it runs locally well and that's fine. I'll temporarily disable detekt for now and resolve it locally. Will enable it later in the workflow |
hieuwu
reviewed
Oct 5, 2023
|
@hieuwu awesome! |
hieuwu
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#181
Added detekt into the project.
Added a github action step to check Detekt as part of the build.
NOTE
At the moment detekt fails due to many issues, so the builds will all fail so we need to either disable the detekt step, capture the baseline for detekt to be able to ignore certain things or fix all the detekt issues...