Migrate standalone role to a collection #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normo
force-pushed
the
165-migrate-role-to-collection
branch
27 times, most recently
from
54100d4
to
b562b02
Compare
Normo
force-pushed
the
165-migrate-role-to-collection
branch
2 times, most recently
from
87d1059
to
400166e
Compare
Normo
force-pushed
the
165-migrate-role-to-collection
branch
from
400166e
to
9a77afb
Compare
Normo
force-pushed
the
165-migrate-role-to-collection
branch
from
9a77afb
to
5e3dba4
Compare
christianhueserhzdr
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Thank you very much, Norman @Normo, for migrating the role to a collection. That's already great work. 👍 I still have a couple of minor questions, though. Could you please take some time to clarify these? Thanks!
Normo
force-pushed
the
165-migrate-role-to-collection
branch
2 times, most recently
from
3ce5b6a
to
7bffdb6
Compare
Normo
force-pushed
the
165-migrate-role-to-collection
branch
from
7bffdb6
to
475c903
Compare
christianhueserhzdr
requested changes
Mar 18, 2024
Normo
force-pushed
the
165-migrate-role-to-collection
branch
3 times, most recently
from
e37104b
to
b93d330
Compare
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
Normo
force-pushed
the
165-migrate-role-to-collection
branch
from
b93d330
to
ccea30a
Compare
christianhueserhzdr
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Thank you very much for these improvements and the thorough implementation, Norman @Normo. I'll approve this PR now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the standalone role to a collection role, which will require a new major release (v4.0.0) that will be contained in a separate release branch.
Related to #165