Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gitlab_runner role into hifis toolkit #216

Merged
merged 3 commits into from
May 16, 2024
Merged

Integrate gitlab_runner role into hifis toolkit #216

merged 3 commits into from
May 16, 2024

Conversation

tobiashuste
Copy link
Member

@tobiashuste tobiashuste commented May 15, 2024 •
edited

  • Integrates the gitlab_runner role into the collection
  • Updates Python to 3.12 as the minimum required version of gitlab_runner role was higher than 3.10
  • Indent README list by 4 spaces hoping that the Ansible galaxy view will be properly rendered

Closes #210

@tobiashuste tobiashuste force-pushed the 210-include-hifisgitlab_runner-role-into-collection branch from 3911685 to 5710f45 Compare May 15, 2024 18:45
@tobiashuste tobiashuste changed the base branch from 210-include-hifisgitlab_runner-role-into-collection to main May 15, 2024 18:45
@tobiashuste tobiashuste force-pushed the 210-include-hifisgitlab_runner-role-into-collection branch 9 times, most recently from 134b0e3 to 913caef Compare May 16, 2024 04:40
@tobiashuste tobiashuste added this to the v4.1.0 milestone May 16, 2024
@tobiashuste tobiashuste linked an issue May 16, 2024 that may be closed by this pull request
Include hifis.gitlab_runner role into collection #210
Closed
@tobiashuste tobiashuste self-assigned this May 16, 2024
@tobiashuste tobiashuste force-pushed the 210-include-hifisgitlab_runner-role-into-collection branch 2 times, most recently from 82fbc5e to a8a5f90 Compare May 16, 2024 08:19
@tobiashuste tobiashuste requested a review from Normo May 16, 2024 08:29
@tobiashuste tobiashuste marked this pull request as ready for review May 16, 2024 08:29
@tobiashuste tobiashuste requested a review from a team as a code owner May 16, 2024 08:29
Normo
Normo requested changes May 16, 2024
View reviewed changes
roles/gitlab_runner/HISTORY.md Outdated Show resolved Hide resolved
roles/gitlab_runner/README.md Show resolved Hide resolved
roles/gitlab_runner/meta/main.yml Outdated Show resolved Hide resolved
@tobiashuste tobiashuste force-pushed the 210-include-hifisgitlab_runner-role-into-collection branch from 4d9eb8e to 3402b90 Compare May 16, 2024 10:49
@tobiashuste tobiashuste requested a review from Normo May 16, 2024 10:52
Normo
Normo previously approved these changes May 16, 2024
View reviewed changes
@tobiashuste tobiashuste force-pushed the 210-include-hifisgitlab_runner-role-into-collection branch from 3402b90 to 3d5f72e Compare May 16, 2024 12:52
@tobiashuste tobiashuste merged commit 7c14225 into hifis-net:main May 16, 2024
28 checks passed
@tobiashuste tobiashuste deleted the 210-include-hifisgitlab_runner-role-into-collection branch May 16, 2024 13:06
@Normo Normo added the gitlab_runner Related to hifis.toolkit.gitlab_runner role label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Normo Normo Normo approved these changes

Assignees

@tobiashuste tobiashuste

Labels
gitlab_runner Related to hifis.toolkit.gitlab_runner role
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Include hifis.gitlab_runner role into collection
2 participants
@tobiashuste @Normo