Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-in Instant Search #13

Open
hifocus opened this issue Aug 20, 2018 · 2 comments
Open

Build-in Instant Search #13

hifocus opened this issue Aug 20, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hifocus
Copy link
Owner

hifocus commented Aug 20, 2018

Is your feature request related to a problem? Please describe.
No. Just want to add the instant search function to apps page

Describe the solution you'd like
In the future we're going to support more and more apps, in the meantime it might be a problem for users to find out if we support a specific app. So a search bar is necessary.

Describe alternatives you've considered
https://www.algolia.com Might be a solution. And also https://github.com/algolia/instantsearch.js

Additional context
I'll try it by myself but I don't think I can get it done. If any of you have ideas just leave a comment below.

@hifocus hifocus added enhancement New feature or request help wanted Extra attention is needed labels Aug 20, 2018
@KeJunMao
Copy link
Collaborator

我觉得无须第三方库,使用 liquid 生成 json,或者生成数组对象,使用 js 索引,或者直接搜索 dom 即可,需要考虑的只有性能。

@hifocus
Copy link
Owner Author

hifocus commented Aug 22, 2018

I think we will need to process all the downloiad links to json format as soon as possible.

The json will include these information:

  1. App Name
  2. App Type (Like Browser, Player, Editor etc.)
  3. Download Link Type (China Optimized, Non China Optimized, Blocked By The Internet Restrict Policy etc.) They should have different reminder in the page
  4. Latest Release Data if possible

For the json format, I still not quite clear about how to fit in the alias system.

And also I don't know should we add in CDN Type or not, that can work with the Download Link Type or not.

Please give out some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants