Sprint1 #1
Merged
Sprint1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: fix todos, do lint, do format |
Add Github Action
Add Github Action
Add Github Action
table: change vector of shared ptr to unique ptr
# Conflicts: # src/lib/storage/table.cpp # src/lib/storage/table.hpp
kris-fillip
approved these changes
Apr 26, 2021
Co-authored-by: simonstadlinger <33035544+simonstadlinger@users.noreply.github.com>
Bensk1
reviewed
Jun 7, 2021
| void Chunk::add_segment(std::shared_ptr<BaseSegment> segment) { | ||
| // Implementation goes here | ||
| } | ||
| void Chunk::add_segment(std::shared_ptr<BaseSegment> segment) { _columns.emplace_back(segment); } |
There was a problem hiding this comment.
What happens if a segment is added to a chunk that already contains values?
Comment on lines
+24
to
+25
| const auto dropped_table_count = _tables.erase(name); | ||
| Assert(dropped_table_count == 1, "Table could not be removed because it was not found."); |
|
|
||
| std::vector<std::string> StorageManager::table_names() const { | ||
| throw std::runtime_error("Implement StorageManager::table_names"); | ||
| auto table_names = std::vector<std::string>{}; | ||
| table_names.reserve(_tables.size()); |
src/lib/storage/table.cpp
Outdated
Comment on lines
45
to
46
| DebugAssert(_chunks.back()->size() != _target_chunk_size, | ||
| "Cannot emplace chunk because current last chunk is not full."); |
There was a problem hiding this comment.
Where is this invariant specified?
src/lib/storage/table.cpp
Outdated
Comment on lines
63
to
65
| if (find_result_iter == _columns.end()) { | ||
| throw std::invalid_argument("Column name does not exists."); | ||
| } |
|
|
||
| void Table::_append_column_to_chunks(const std::string& type) { | ||
| DebugAssert(row_count() == 0, "Cannot append new columns to already existing chunks."); | ||
| for (const auto& chunk : _chunks) { |
There was a problem hiding this comment.
If row_count() == 0 there should be only one chunk.
|
|
||
| // Returns a list of all column names. | ||
| const std::vector<std::string>& column_names() const; | ||
| const std::vector<std::string> column_names() const; |
There was a problem hiding this comment.
The public interface was not supposed to be changed. But we can see that you had to do it due to your self-defined Column data type.
| EXPECT_THROW(t.column_id_by_name("no_column_name"), std::exception); | ||
| } | ||
|
|
||
| TEST_F(StorageTableTest, GetChunkSize) { EXPECT_EQ(t.target_chunk_size(), 2u); } |
There was a problem hiding this comment.
In my opinion, the test's name is suboptimal.
mweisgut
reviewed
Jun 7, 2021
| @@ -10,38 +10,47 @@ | |||
| namespace opossum { | |||
|
|
|||
| StorageManager& StorageManager::get() { | |||
| return *(new StorageManager()); | |||
| // A really hacky fix to get the tests to run - replace this with your implementation | |||
| static StorageManager _instance; | |||
There was a problem hiding this comment.
We only use a leading underscore for private/protected members/methods but not for local variables, see CONTRIBUTING.md.
| std::vector<std::unique_ptr<Chunk>> _chunks; | ||
| std::vector<Column> _columns; | ||
|
|
||
| // TODO(hig): If we need this more often, consider to move this to BaseSegment or ValueSegment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.