Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps1: cache isolate bit should isolate i-cache, not d-cache (scratchpad) #115

Merged
merged 1 commit into from Oct 3, 2020

Conversation

LukeUsher
Copy link
Contributor

One obvious improvement is that this solves the 'black road' issue in Ridge Racer (note that the broken polygons are part of an unrelated problem)

As this is such a fundamental flaw, chances are there are significant improvements to other games too.

before:
before

after:
after

@PatrickvL
Copy link

...and how does this title look in PolyBlast? ;)

@ghost
Copy link

ghost commented Oct 3, 2020

This is a definite improvement, but my understanding is cache isolate can isolate both caches (or both tag line caches with the caveat that there are no data cache tags) based on the settings of $fffe:0130. I don't know the exact combinations that enable what, but there's bits for tag testing and code/data/stratchpad enable, among many other settings.

@LukeUsher
Copy link
Contributor Author

This is a definite improvement, but my understanding is cache isolate can isolate both caches (or both tag line caches with the caveat that there are no data cache tags) based on the settings of $fffe:0130. I don't know the exact combinations that enable what, but there's bits for tag testing and code/data/stratchpad enable, among many other settings.

Has this behaviour been hardware tested at all? We know the data cache and other cache-related portions are different on the ps1 cpu than other chips of the same family.

@Screwtapello Screwtapello merged commit 4fa0973 into higan-emu:master Oct 3, 2020
@Screwtapello
Copy link
Contributor

Thanks for figuring this out!

@LukeUsher LukeUsher deleted the ps1-fix-cache-isolate branch November 2, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants