Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow USER@FQDN format for bootstrap (and chef_client?) commands #37

Closed
patcon opened this issue Jun 11, 2015 · 7 comments
Closed

Allow USER@FQDN format for bootstrap (and chef_client?) commands #37

patcon opened this issue Jun 11, 2015 · 7 comments

Comments

@patcon
Copy link
Contributor

patcon commented Jun 11, 2015

Knife-solo does this and it's pretty convenient:

It's a little less elegant here, as chef_client takes a QUERY argument right now. It might make a little more sense if #33 were a thing, and a non-query was assumed to be a key for fqdn.

This would allow the process to go from:

knife zero bootstrap myproject-vagrant --ssh-user=vagrant --run-list='role[myproject]'
# creates my user on the machine, as it would on a remote server
zero chef_client name:cmha-local --ssh-user=patcon --sudo

to this:

knife zero bootstrap vagrant@myproject-vagrant --run-list='role[myproject]'
knife zero chef_client patcon@cmha-local --sudo

Which seems a bit cleaner for project setup instructions

@sawanoboly
Copy link
Member

--ssh-user was just inherited(copy) from chef-core.

If limited to the case of bootstraping, using user@hostname format could be nice. I think it also supported by the chef-core.

And I think Chef-Server users(like me) are familiar with QUERY than knife-solo usage.

@patcon
Copy link
Contributor Author

patcon commented Jun 12, 2015

From the cli docs, I wasn't aware chef-core supported this, but perhaps it would be best-suited there, so knife-zero would get it for free :)

@patcon
Copy link
Contributor Author

patcon commented Jun 12, 2015

Created a core issue here as well: chef/chef#3527

@patcon
Copy link
Contributor Author

patcon commented Jun 12, 2015

OK, submitted a PR upstream. Thanks! Feel free to +1 the feature if you think it's valuable

@sawanoboly
Copy link
Member

@sawanoboly
Copy link
Member

Released as v1.11.0, Thanks 👍

@patcon
Copy link
Contributor Author

patcon commented Dec 31, 2015

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants