[knife] Allow ssh_user arg to be set inline via knife bootstrap user@hostname

[patcon]

The thought was that this format might be more intuitive and aligned with expectations outside chef narnia :)

Thoughts?

[patcon]

If this gets the ok, this is the only place where it would seem a test could be added (copy-pasting the scenario and tweaking), right?

chef/spec/unit/knife/bootstrap_spec.rb

Lines 398 to 436 in b08c901

	describe "when configuring the underlying knife ssh command" do
	context "from the command line" do
	let(:knife_ssh) do
	knife.name_args = ["foo.example.com"]
	knife.config[:ssh_user] = "rooty"
	knife.config[:ssh_port] = "4001"
	knife.config[:ssh_password] = "open_sesame"
	Chef::Config[:knife][:ssh_user] = nil
	Chef::Config[:knife][:ssh_port] = nil
	knife.config[:forward_agent] = true
	knife.config[:identity_file] = "~/.ssh/me.rsa"
	allow(knife).to receive(:render_template).and_return("")
	knife.knife_ssh
	end
	it "configures the hostname" do
	expect(knife_ssh.name_args.first).to eq("foo.example.com")
	end
	it "configures the ssh user" do
	expect(knife_ssh.config[:ssh_user]).to eq('rooty')
	end
	it "configures the ssh password" do
	expect(knife_ssh.config[:ssh_password]).to eq('open_sesame')
	end
	it "configures the ssh port" do
	expect(knife_ssh.config[:ssh_port]).to eq('4001')
	end
	it "configures the ssh agent forwarding" do
	expect(knife_ssh.config[:forward_agent]).to eq(true)
	end
	it "configures the ssh identity file" do
	expect(knife_ssh.config[:identity_file]).to eq('~/.ssh/me.rsa')
	end
	end

[sawanoboly]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.