Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comparision of X86Opnd #177

Merged
merged 1 commit into from Feb 2, 2015
Merged

fix comparision of X86Opnd #177

merged 1 commit into from Feb 2, 2015

Conversation

MartinNowak
Copy link
Contributor

  • need to switch on kind for comparision

@MartinNowak
fix comparision of X86Opnd
866220c 
- need to switch on kind for comparision
@maximecb
Copy link
Contributor

maximecb commented Feb 2, 2015

Don't structs without opEquals just do a direct memory comparison?

@MartinNowak
Copy link
Contributor Author

Don't structs without opEquals just do a direct memory comparison?

They do by field comparison which can optimized to memcmp sometimes.
The problem here is that depending on which union member is used, you need to compare more or less memory as the rest isn't cleared on assignment/initialization.
https://issues.dlang.org/show_bug.cgi?id=13952

maximecb added a commit that referenced this pull request Feb 2, 2015
@maximecb
Merge pull request #177 from MartinNowak/fixCompX86Opnd
f9647d0 
fix comparision of X86Opnd
@maximecb maximecb merged commit f9647d0 into higgsjs:master Feb 2, 2015
@MartinNowak MartinNowak deleted the fixCompX86Opnd branch February 2, 2015 20:22
@MartinNowak MartinNowak mentioned this pull request Mar 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MartinNowak @maximecb