Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Conflict with RequireJS #112

Merged

Conversation

hcpchris
Copy link
Collaborator

Implemented brute-force split logic. If RequireJS is present in the JavaScript environment, applies RequireJS-specific syntax. If RequireJS is not present, then applies non-RequireJS syntax using async promises. Tests seem to be passing in:

  • Jupyter Lab (where RequireJS is not used)
  • Jupyter Notebook (where RequireJS is used)
  • Static HTML saved using nbconvert (where RequireJS is used)

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage: 42.32% and project coverage change: -0.40% ⚠️

Comparison is base (a82cc75) 89.15% compared to head (2d307d3) 88.75%.
Report is 17 commits behind head on v.1.4-rc-branch.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           v.1.4-rc-branch     #112      +/-   ##
===================================================
- Coverage            89.15%   88.75%   -0.40%     
===================================================
  Files                  207      208       +1     
  Lines                29596    29838     +242     
  Branches              2243     2292      +49     
===================================================
+ Hits                 26386    26484      +98     
- Misses                2384     2502     +118     
- Partials               826      852      +26     
Files Changed Coverage Δ
highcharts_core/headless_export.py 73.24% <ø> (ø)
highcharts_core/chart.py 50.00% <5.26%> (-4.16%) ⬇️
highcharts_core/utility_functions.py 45.39% <10.00%> (-1.78%) ⬇️
highcharts_core/ai.py 45.03% <45.03%> (ø)
...harts_core/utility_classes/javascript_functions.py 87.05% <56.66%> (-4.21%) ⬇️
highcharts_core/options/series/base.py 71.98% <65.21%> (-0.44%) ⬇️
highcharts_core/js_literal_functions.py 58.96% <66.66%> (+0.04%) ⬆️
highcharts_core/errors.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcpchris hcpchris merged commit 24dfffc into v.1.4-rc-branch Sep 23, 2023
1 of 3 checks passed
@hcpchris hcpchris deleted the BUG/66-conflict-with-requirejs-in-exported-notebooks branch September 23, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant