Optional EventListener on Chart.to_js_literal #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore all the line ending diff's. (I'm guessing it's because I'm on Linux or haven't configured my Git client to ignore it)
The change is on line 512/513 and 602-608
I needed a chart which doesn't require an eventlistener as it's loaded on click using HTMX instead of JS, because I'm using HTMX, the DOMContentLoaded isn't being triggered. Using this change I can have the JS code executed immediately instead. This change also allows you to use any other EventListener by providing it as a string.