Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal wont close. #79

Closed
VictorioBerra opened this issue Dec 2, 2016 · 3 comments
Closed

Modal wont close. #79

VictorioBerra opened this issue Dec 2, 2016 · 3 comments

Comments

@VictorioBerra
Copy link

I wish I could provide a fiddle but since the assets are zipped and not hosted on a CDN I cant do that yet. I am also inside an AngularJS app if that matters.

Chrome - Version 54.0.2840.99 m (64-bit)
highed - v0.1.1-beta

highed.ModalEditor(document.body, {
    features: 'customize done'
});
@cvasseng
Copy link
Contributor

cvasseng commented Dec 3, 2016

Hi, are you getting any errors in the chrome console when trying to close it?

@VictorioBerra
Copy link
Author

VictorioBerra commented Dec 3, 2016 via email

@cvasseng
Copy link
Contributor

cvasseng commented Dec 7, 2016

Hi, the first argument to highed.ModalEditor is the node which should summon the editor - not the target for the editor itself. See docs here.

Try:

highed.ModalEditor('my-button', {
    ...
});

Instead, where 'my-button' is the id of the button that should spawn the modal editor. There's no need to add additional event listeners on the button, the modal editor does that for you.

@cvasseng cvasseng closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants