Fixed issue with input range where the range would be reset based on …

…wrong extremes. Ref #5602.
highcharts · Oct 19, 2016 · 4ab11d6 · 4ab11d6
1 parent afb483e
commit 4ab11d6
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/js/parts/RangeSelector.js b/js/parts/RangeSelector.js
@@ -465,9 +465,10 @@ RangeSelector.prototype = {
 		function updateExtremes() {
 			var inputValue = input.value,
 				value = (options.inputDateParser || Date.parse)(inputValue),
-				xAxis = chart.scroller && chart.scroller.xAxis ? chart.scroller.xAxis : chart.xAxis[0],
-				dataMin = xAxis.dataMin,
-				dataMax = xAxis.dataMax;
+				chartAxis = chart.xAxis[0],
+				dataAxis = chart.scroller && chart.scroller.xAxis ? chart.scroller.xAxis : chartAxis,
+				dataMin = dataAxis.dataMin,
+				dataMax = dataAxis.dataMax;
 			if (value !== input.previousValue) {
 				input.previousValue = value;
 				// If the value isn't parsed directly to a value by the browser's Date.parse method,
@@ -502,9 +503,9 @@ RangeSelector.prototype = {
 
 					// Set the extremes
 					if (value !== undefined) {
-						chart.xAxis[0].setExtremes(
-							isMin ? value : xAxis.min,
-							isMin ? xAxis.max : value,
+						chartAxis.setExtremes(
+							isMin ? value : chartAxis.min,
+							isMin ? chartAxis.max : value,
 							undefined,
 							undefined,
 							{ trigger: 'rangeSelectorInput' }

diff --git a/samples/unit-tests/rangeselector/input-range/demo.details b/samples/unit-tests/rangeselector/input-range/demo.details
@@ -0,0 +1,5 @@
+---
+ resources:
+   - https://code.jquery.com/qunit/qunit-1.19.0.js
+   - https://code.jquery.com/qunit/qunit-1.19.0.css
+...
diff --git a/samples/unit-tests/rangeselector/input-range/demo.html b/samples/unit-tests/rangeselector/input-range/demo.html
@@ -0,0 +1,6 @@
+<script src="https://code.highcharts.com/stock/highstock.js"></script>
+
+<div id="qunit"></div>
+<div id="qunit-fixture"></div>
+
+<div id="container" style="width: 600px; margin: 0 auto"></div>