Fixed #16673, labels in treeGrid were not destroyed after an update.

highcharts · Dec 9, 2021 · 99b76c0 · 99b76c0
1 parent d88ad82
commit 99b76c0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/samples/unit-tests/gantt/treegrid/demo.js b/samples/unit-tests/gantt/treegrid/demo.js
@@ -516,4 +516,11 @@ QUnit.test('series.data[].collapsed', assert => {
         false,
         'This point should be expanded #13838'
     );
+
+    chart.series[0].setData([], true, true, false);
+    assert.notOk(
+        document.querySelector('.highcharts-label-icon'),
+        `After updating data,
+        the unnecessary label icons should be removed, 16673.`
+    );
 });
diff --git a/ts/Core/Axis/TreeGridTick.ts b/ts/Core/Axis/TreeGridTick.ts
@@ -466,6 +466,18 @@ namespace TreeGridTick {
             }
         }
 
+        /**
+         * Destroy remaining labelIcon if exist.
+         *
+         * @private
+         * @function Highcharts.Tick#destroy
+         */
+        public destroy(): void {
+            if (this.labelIcon) {
+                this.labelIcon.destroy();
+            }
+        }
+
         /**
          * Expand the grid cell. Used when axis is of type treegrid.
          *