Fixed #6769, hidden series legend had invalid stroke-width attribute.

highcharts · May 26, 2017 · d542b6c · d542b6c
1 parent 6b8b3ef
commit d542b6c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/js/parts/Legend.js b/js/parts/Legend.js
@@ -134,12 +134,9 @@ Highcharts.Legend.prototype = {
 
 			// Apply marker options
 			if (markerOptions && legendSymbol.isMarker) { // #585
-				//symbolAttr.stroke = symbolColor;
 				symbolAttr = item.pointAttribs();
 				if (!visible) {
-					H.objectEach(symbolAttr, function (val, key) {
-						symbolAttr[key] = hiddenColor;
-					});
+					symbolAttr.stroke = symbolAttr.fill = hiddenColor; // #6769
 				}
 			}
 

diff --git a/samples/unit-tests/legend/legend-general/demo.js b/samples/unit-tests/legend/legend-general/demo.js
@@ -34,3 +34,32 @@ QUnit.test('Spacing and legend overflow (#6497)', function (assert) {
         'Legend is within spacing'
     );
 });
+
+QUnit.test('Hidden legend bogus SVG (#6769', function (assert) {
+
+    var chart = Highcharts.chart('container', {
+        credits: {
+            enabled: false
+        },
+        title: {
+            text: ''
+        },
+        yAxis: {
+            visible: false
+        },
+        xAxis: {
+            visible: false
+        },
+        series: [{
+            data: [1],
+            visible: false
+        }]
+    });
+
+    assert.strictEqual(
+        chart.container.innerHTML.indexOf('stroke-width="#'),
+        -1,
+        'No bogus stroke-width found'
+    );
+
+});