Skip to content

Commit

Permalink
Touch #13711, changed the sample location and variable name.
Browse files Browse the repository at this point in the history
  • Loading branch information
karolkolodziej committed Sep 2, 2020
1 parent a17e04a commit d5b9ec1
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 21 deletions.
10 changes: 5 additions & 5 deletions js/Extensions/Drilldown.js
Expand Up @@ -406,7 +406,7 @@ defaultOptions.drilldown = {
*
* @sample {highcharts} highcharts/drilldown/basic/
* Basic drilldown
* @sample {highcharts} highcharts/demo/organization-drilldown
* @sample {highcharts} highcharts/series-organization/drilldown
* Organization chart drilldown
*
* @type {string}
Expand Down Expand Up @@ -775,14 +775,14 @@ ColumnSeries.prototype.animateDrillupTo = function (init) {
syncTimeout(function () {
if (newSeries.points) { // May be destroyed in the meantime, #3389
// Unable to drillup with nodes, #13711
var seriesWithNodes = [];
var pointsWithNodes = [];
newSeries.data.forEach(function (el) {
seriesWithNodes.push(el);
pointsWithNodes.push(el);
});
if (newSeries.nodes) {
seriesWithNodes = seriesWithNodes.concat(newSeries.nodes);
pointsWithNodes = pointsWithNodes.concat(newSeries.nodes);
}
seriesWithNodes.forEach(function (point, i) {
pointsWithNodes.forEach(function (point, i) {
// Fade in other points
var verb = i === (level && level.pointIndex) ? 'show' : 'fadeIn', inherit = verb === 'show' ? true : void 0, dataLabel = point.dataLabel;
if (point.graphic) { // #3407
Expand Down
1 change: 0 additions & 1 deletion samples/highcharts/demo/index.htm
Expand Up @@ -157,7 +157,6 @@ <h4>More chart types</h4>
<li><a href="examples/sankey-diagram/index.htm">Sankey diagram</a></li>
<li><a href="examples/dependency-wheel/index.htm">Dependency wheel</a></li>
<li><a href="examples/organization-chart/index.htm">Organization chart</a></li>
<li><a href="examples/organization-drilldown/index.htm">Organization chart</a></li>
<li><a href="examples/x-range/index.htm">X-range series</a></li>
<li><a href="examples/wordcloud/index.htm">Word cloud</a></li>
<li><a href="examples/column-pyramid/index.htm">Column pyramid chart</a></li>
Expand Down
10 changes: 0 additions & 10 deletions samples/highcharts/demo/organization-drilldown/demo.details

This file was deleted.

6 changes: 6 additions & 0 deletions samples/highcharts/series-organization/drilldown/demo.details
@@ -0,0 +1,6 @@
---
name: Highcharts Demo
authors:
- Torstein Hønsi
js_wrap: b
...
10 changes: 5 additions & 5 deletions ts/Extensions/Drilldown.ts
Expand Up @@ -621,7 +621,7 @@ defaultOptions.drilldown = {
*
* @sample {highcharts} highcharts/drilldown/basic/
* Basic drilldown
* @sample {highcharts} highcharts/demo/organization-drilldown
* @sample {highcharts} highcharts/series-organization/drilldown
* Organization chart drilldown
*
* @type {string}
Expand Down Expand Up @@ -1122,14 +1122,14 @@ ColumnSeries.prototype.animateDrillupTo = function (init?: boolean): void {
syncTimeout(function (): void {
if (newSeries.points) { // May be destroyed in the meantime, #3389
// Unable to drillup with nodes, #13711
var seriesWithNodes: Array<any> = [];
var pointsWithNodes: Array<any> = [];
newSeries.data.forEach(function (el): void {
seriesWithNodes.push(el);
pointsWithNodes.push(el);
});
if (newSeries.nodes) {
seriesWithNodes = seriesWithNodes.concat(newSeries.nodes);
pointsWithNodes = pointsWithNodes.concat(newSeries.nodes);
}
seriesWithNodes.forEach(function (
pointsWithNodes.forEach(function (
point: Point,
i: number
): void {
Expand Down

0 comments on commit d5b9ec1

Please sign in to comment.