Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked series become inverted after update #1119

Closed
eolsson opened this issue Jul 18, 2012 · 17 comments
Closed

Stacked series become inverted after update #1119

eolsson opened this issue Jul 18, 2012 · 17 comments

Comments

@eolsson
Copy link
Contributor

eolsson commented Jul 18, 2012

  1. Open http://jsfiddle.net/TheEvilHammer/MqJSR/7/
  2. Wait 5 seconds for the timer to add data points

Result: The areas are now inverted and goes below the x axis.
Expected: The stacks to build up instead of down.

Note: This does not happen when removing stacking: 'normal'

@TorsteinHonsi
Copy link
Collaborator

Reduced example: http://jsfiddle.net/highcharts/MqJSR/11/

When disabling the navigator the bug doesn't happen

@ghost
Copy link

ghost commented Aug 20, 2012

Any update on this? This is a showstopper for us because it renders charts pretty much unusable.

@TorsteinHonsi
Copy link
Collaborator

I'll get back to this once 2.3 is out (one of these days)

@ghost
Copy link

ghost commented Sep 5, 2012

Any updates now that Highcharts 2.3 is out?

@TorsteinHonsi
Copy link
Collaborator

I'm sorry, we still have this issue on top priority. I'm going away the
next week so there won't be much time for developing the next two weeks,
but I'll get at it as soon as possible.

@TorsteinHonsi
Copy link
Collaborator

Hi again, I couldn't get peace over this so I hacked away for two hours at this well-hidden bug. Finally tracked it down to the afterExtremes event that triggered a chart.redraw inside another chart.redraw, causing recursion because series were still marked dirty. Hope the fix helps, and doesn't cause other issues related to this very sensitive part of the Highstock logic.

@ghost
Copy link

ghost commented Sep 6, 2012

Fantastic! Thank you very much for looking into this. Do you know when the next point release of Highstock will be?

@TorsteinHonsi
Copy link
Collaborator

Not exactly, but we typically have cycles of one month. Until then, I
recommend that you grab the diff, apply it to the current stable version of
highstock.src.js and compile it online at the Closure Compiler.

@ghost
Copy link

ghost commented Sep 21, 2012

I don't know if manually patching the code is going to work for us; we need an official Highstock release. It's been a couple weeks since your last post, do you have a better idea as to when the next release will be? This is a high priority bug for us and we'd like to upgrade Highstock as our dev cycle is coming to an end very soon.

@TorsteinHonsi
Copy link
Collaborator

We're in the middle of some heavy refactoring of data labels now, but when
we've finished that and a couplye of other issues, we'll start testing for
a new release. It can be expected this week or the next.

@ghost
Copy link

ghost commented Sep 24, 2012

Fantastic, thank you for the update.

@ghost
Copy link

ghost commented Sep 26, 2012

I've been doing some testing with this patch and I don't know if the issue is completely fixed. I took the source from 1.2.2, applied the patch manually, ran it through Google's Closure Compiler, and deployed to my webapp. The original issue (where all series were inverted) has been fixed, but I'm still seeing weirdness where one series is inverted, plus there will be empty space where a series is missing, plus weird rendering problems.

Screenshot: http://i.imgur.com/GMQmf.png

@ghost
Copy link

ghost commented Sep 27, 2012

I have also been able to easily repro this problem with the very latest version of highstock.src.js, so it's not an issue of me messing up the manual patching. Unlike the original fiddle I posted, it takes several updates (up to a few minutes' worth) to trigger this new issue.

@ghost
Copy link

ghost commented Sep 27, 2012

Here's a screencast of the inversion problem with the latest Highstock source: http://youtu.be/0K7t1qDOONI

@ghost
Copy link

ghost commented Sep 27, 2012

Here's a jsfiddle that repros the issue within a few seconds: http://jsfiddle.net/TheEvilHammer/hywbV/11/show/

This fiddle is pointing to the most recent copy of highstock.src.js in github. How soon do you think you could have a fix for this?

@TorsteinHonsi
Copy link
Collaborator

Thanks for reporting, I've logged this new bug at
#1259. Will look
at it as soon as possible.

@ghost
Copy link

ghost commented Sep 27, 2012

Excellent, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants