softMin causes maxPadding to be ignored for certain cases

[awonihlgard]

Expected behaviour

There should be a padding between the serie maximum and the chart maximum that can be controlled with maxPadding

Actual behaviour

maxPadding is not respected, causing the serie to end up to close to the chart edge

Live demo with steps to reproduce

https://jsfiddle.net/zjx86fvm/50/

• If softMin is replaced with min, the padding is added
• If the series have a higher variance (e.g replace the first data point with 220), the padding is added

Product version

Highcharts 10.2.0

Affected browser(s)

[karolkolodziej]

Hi @awonihlgard, thank you for reporting this issue.

Internal note:
The part responsible for calculating the min/max from softMin/softMax

highcharts/ts/Core/Axis/Axis.ts

Lines 1732 to 1774 in de6aa18

	// Pad the values to get clear of the chart's edges. To avoid
	// tickInterval taking the padding into account, we do this after
	// computing tick interval (#1337).
	if (
	!categories &&
	!axis.axisPointRange &&
	!(axis.stacking && axis.stacking.usePercentage) &&
	!isLinked &&
	defined(axis.min) &&
	defined(axis.max)
	) {
	length = axis.max - axis.min;
	if (length) {
	if (!defined(hardMin) && minPadding) {
	axis.min -= length * minPadding;
	}
	if (!defined(hardMax) && maxPadding) {
	axis.max += length * maxPadding;
	}
	}
	}
	// Handle options for floor, ceiling, softMin and softMax (#6359)
	if (!isNumber(axis.userMin)) {
	if (
	isNumber(options.softMin) && options.softMin < (axis.min as any)
	) {
	axis.min = hardMin = options.softMin; // #6894
	}
	if (isNumber(options.floor)) {
	axis.min = Math.max(axis.min as any, options.floor);
	}
	}
	if (!isNumber(axis.userMax)) {
	if (
	isNumber(options.softMax) && options.softMax > (axis.max as any)
	) {
	axis.max = hardMax = options.softMax; // #6894
	}
	if (isNumber(options.ceiling)) {
	axis.max = Math.min(axis.max as any, options.ceiling);
	}
	}

is called after the part where the padding is added.

Simply revert that order and run some regression tests.
Needs deeper analysis.

[awonihlgard]

Any progress on this?

[karolkolodziej]

@awonihlgard We started working on that, please follow the issue to get more updates on the fix.