Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing breadcrumbs after setting the update flag to true #19616

Closed
kamil-musialowski opened this issue Aug 24, 2023 · 3 comments · Fixed by #19652
Closed

Disappearing breadcrumbs after setting the update flag to true #19616

kamil-musialowski opened this issue Aug 24, 2023 · 3 comments · Fixed by #19652

Comments

@kamil-musialowski
Copy link
Contributor

Actual behaviour

Breadcrumbs disappear after calling the chart update method.

Live demo with steps to reproduce

https://jsfiddle.net/BlackLabel/jtq1yaz3/

Click on the Level 2.2 node.
Click the button.
Watch how breadcrumbs disappear.

Product version

HC + Sunburst 11.1.0

@jakubjanuchta
Copy link
Contributor

jakubjanuchta commented Aug 25, 2023

I wanted to check how does updating the data affect other series with drilldown and I got interesting results.

In column with drilldown, when you update the data after the drilldown, the breadcrumbs are intact, but the chart is updated and the new data is shown (which means that the breadcrumbs are totally misaligned with the data), see demo.
To reproduce - drill down and click any of the buttons.
image

Moreover, on pie with drilldown series when we drill down, than update the chart with new data, the breadcrumbs are still intact and missaligned with the data, but if we drilldown once more after that, the pie's are drawn on each other breaking the chart, see demo

image

I think we should implement the same breadcrumbs behavior for all the drilldown series and I believe the breadcrumbs should disappear after updating the data and the series should be brought back to it's initial state before drilldown (no matter if we update with different data or the same one).

What do you think about that @TorsteinHonsi? If you agree, should I implement it along with this ticket or should I create another one?

@TorsteinHonsi
Copy link
Collaborator

@jakubjanuchta Actually there's a fundamental difference between the drilldown of columns and pies, and the traverse feature of treemaps and sunbursts:

  • In the drilldown module, clicking one point opens up a whole new series, either of the same or of a different type.
  • When traversing sunburst and treemaps, clicking one node sets the root of the tree to that node, but no series swapping is involved. By a bad choice, we previously (and confusingly) used the term drilldown to this functionality too.
  • The Breadcrumbs module is used by both sets of functionality.

So, in summary, I think we should limit the scope of this issue to traversing sunburst/treemaps only. If we learn something that we can use in the drilldown module too, it's a good start, but should probably happen in a different issue.

@jakubjanuchta
Copy link
Contributor

@jakubjanuchta Actually there's a fundamental difference between the drilldown of columns and pies, and the traverse feature of treemaps and sunbursts:

  • In the drilldown module, clicking one point opens up a whole new series, either of the same or of a different type.
  • When traversing sunburst and treemaps, clicking one node sets the root of the tree to that node, but no series swapping is involved. By a bad choice, we previously (and confusingly) used the term drilldown to this functionality too.
  • The Breadcrumbs module is used by both sets of functionality.

So, in summary, I think we should limit the scope of this issue to traversing sunburst/treemaps only. If we learn something that we can use in the drilldown module too, it's a good start, but should probably happen in a different issue.

Thanks for explaining @TorsteinHonsi!

I'll limit this ticket only to traversing functionality and I'll open a new one regarding updating the data in series with drilldown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants