New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sass !default for configurable variables #6436

Closed
alifr opened this Issue Mar 6, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@alifr

alifr commented Mar 6, 2017

Expected behaviour

The variables in the highcharts/css/highcharts.scss should have the !default flag. Then we could import the scss file into our project and override the theme styles without having to duplicate the entire file.

Example

@import 'https://code.highcharts.com/5/css/highcharts.css';

$colors: #40bfa2 #984e9b #fb7830 #01acc8 #CDAED1 #82368C #AAAEB2 #565E65 #EF92A5 #DF264C #565E65 #A8E9F3 #FFBA9D #FF763B #95FEDB #27CAE1;

@TorsteinHonsi

This comment has been minimized.

Show comment
Hide comment
@TorsteinHonsi

TorsteinHonsi Mar 14, 2017

Collaborator

Thanks for your suggestion!

We had a pull request for this a couple of months back, but it broke our build system because the SASS variables are also inserted directly into the generated source code. So we'll have to fix that first. See #6009.

Collaborator

TorsteinHonsi commented Mar 14, 2017

Thanks for your suggestion!

We had a pull request for this a couple of months back, but it broke our build system because the SASS variables are also inserted directly into the generated source code. So we'll have to fix that first. See #6009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment