Fixed #9838, dissappearing traverseUpButton #10014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TorsteinHonsi
requested changes
Feb 1, 2019
There was a problem hiding this comment.
The traverse up button is now missing on sunbursts: https://jsfiddle.net/highcharts/1nruLkcm/3/. On the master it is there.
|
@TorsteinHonsi Please see latest changes. Sadly, for some reason the github.highcharts.com did not update the sunburst.js with the commit, but testing the demo against the local branch will show that it is working again. |
TorsteinHonsi
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
Series.updateis called after the user has traversed down a treemap, thetraverseUpButtonwill dissapear. This is caused by the button is only rendered whensetRootNodeis called, which does not cover all scenarios. Solved by moving the rendering of the button toSeries.translate.Example(s)
Related issue(s)