Feature/chart menu a11y rewrite #12032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oysteinmoseng
added
the
Changelog: Bugfix
|
One comment: After the rewrite, a comma was left over at the end of a function call argument list. This was not caught by linting, but could it be? |
TorsteinHonsi
approved these changes
Sep 20, 2019
Yes, if there's an ESLint rule for it, we should enable it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved screen reader compatibility for chart export menu.
This PR changes a few things logic wise for the export menu a11y handling. The main difference is the different ARIA attribs used, and the location in the DOM of the proxy containers. In addition, the relevant code has been cleaned up some.
Changes to non-a11y code:
An exception was added to the unit test testing for unwanted attribs in styled mode, if the
highcharts-a11y-proxy-buttonclass is set. This because we don't want to confuse users by adding style for the visually hidden proxy buttons in our CSS. Previously these buttons were outside the container tested with the unit test, so this was not an issue.A new event,
chart.exportMenuShown, was added in exporting.ts - complimenting the existingchart.exportMenuHidden.