Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/13042-getTimezoneOffset-param-type #13052

Merged
merged 2 commits into from Mar 6, 2020
Merged

bugfix/13042-getTimezoneOffset-param-type #13052

merged 2 commits into from Mar 6, 2020

Conversation

bre1470
Copy link
Contributor

@bre1470 bre1470 commented Mar 2, 2020 •
edited by TorsteinHonsi

Fixed #13042, getTimezoneOffset callback passed inconsistent value type.

@bre1470 bre1470 self-assigned this Mar 2, 2020
@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

mediafreakch
mediafreakch reviewed Mar 3, 2020
View reviewed changes
ts/parts/Time.ts Outdated Show resolved Hide resolved
TorsteinHonsi
TorsteinHonsi approved these changes Mar 6, 2020
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi added the Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. label Mar 6, 2020
@TorsteinHonsi TorsteinHonsi merged commit fc0f902 into master Mar 6, 2020
@TorsteinHonsi TorsteinHonsi deleted the bugfix/13042-getTimezoneOffset-param-type branch March 6, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mediafreakch mediafreakch mediafreakch left review comments

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees

@bre1470 bre1470

Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getTimeZoneOffset callback passes inconsistent value type
4 participants
@bre1470 @highsoft-bot @TorsteinHonsi @mediafreakch