Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts/logarithmicaxis #13191

Merged
merged 11 commits into from
Mar 27, 2020
Merged

ts/logarithmicaxis #13191

merged 11 commits into from
Mar 27, 2020

Conversation

bre1470
Copy link
Contributor

@bre1470 bre1470 commented Mar 24, 2020 •
edited

@bre1470 bre1470 self-assigned this Mar 24, 2020
@highsoft-bot highsoft-bot added this to Pending Review in Development-Flow via automation Mar 24, 2020
@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Mar 24, 2020 •
edited

Visual test results - No difference found

Samples changed

Change type Sample
Modified samples/highcharts/coloraxis/logarithmic-with-emulate-negative-values/demo.js
Added samples/highcharts/yaxis/type-log-negative-legacy/demo.js
Modified samples/highcharts/yaxis/type-log-negative/demo.js

pawelfus
pawelfus approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update demos and create a test for wrap() ?

TorsteinHonsi
TorsteinHonsi requested changes Mar 25, 2020
View reviewed changes
ts/parts/Axis.ts Outdated Show resolved Hide resolved
ts/parts/Axis.ts Outdated Show resolved Hide resolved
pawelfus
pawelfus reviewed Mar 26, 2020
View reviewed changes
js/parts/Utilities.js Outdated Show resolved Hide resolved
@bre1470 bre1470 self-assigned this Mar 26, 2020
TorsteinHonsi
TorsteinHonsi requested changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline comments, I see the last commit was to put lin2log and log2lin back on the main Axis. Why was that?

ts/parts/LogarithmicAxis.ts Show resolved Hide resolved
ts/parts/LogarithmicAxis.ts Outdated Show resolved Hide resolved
TorsteinHonsi
TorsteinHonsi requested changes Mar 26, 2020
View reviewed changes
ts/parts/LogarithmicAxis.ts Outdated Show resolved Hide resolved
@TorsteinHonsi TorsteinHonsi merged commit daddf2e into master Mar 27, 2020
Development-Flow automation moved this from Pending Review to Done Mar 27, 2020
@TorsteinHonsi TorsteinHonsi deleted the ts/logarithmicaxis branch March 27, 2020 12:51
@Izothep Izothep removed this from Done in Development-Flow Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelfus pawelfus pawelfus approved these changes

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bre1470 @highsoft-bot @TorsteinHonsi @pawelfus