bugfix/13710-pie-drawempty-regression

[goransle]

Fixed #13710, a regression causing errors on empty pie series.

Seems this one snuck out from the fix in 8.12.

With fix: https://codesandbox.io/s/highcharts-vue-demo-b37nm?file=/src/main.js
Without fix: https://codesandbox.io/s/highcharts-vue-demo-ye65e

[highsoft-bot]

Visual test results - No difference found

[highsoft-bot]

File size comparison

	master	candidate	difference
highcharts	263.4 kB	263.4 kB	4 B
highcharts, gzipped	91.2 kB	91.2 kB	-18 B
highstock	342.1 kB	342.1 kB	4 B
highstock, gzipped	117.3 kB	117.4 kB	93 B
highmaps	311.9 kB	311.9 kB	7 B
highmaps, gzipped	106.6 kB	106.6 kB	-31 B
highcharts-gantt	354.7 kB	354.7 kB	7 B
highcharts-gantt, gzipped	121.4 kB	121.4 kB	5 B

[pawelfus]

I might be wrong, but shouldn't we:

• import renderer: import SVGRenderer from '../parts/SVGRenderer.js';
• then use SVGRenderer.prototype.symbols ?

What do you think @bre1470 ?

[pawelfus]

Thanks!

[bre1470]

Looks good! 👍

[TorsteinHonsi]

Thanks!

[TorsteinHonsi]

@bre1470 Looks like another case where the Highcharts namespace slipped through and passed the ESLint validation... Can we update the validation to catch this?

I'm merging this PR though, as it is critical. But we should have a test that catch it in the QA process.

[felipemfp]

@TorsteinHonsi when this fix will be released? I'm asking because in our project we need the vulnerability fix on latest, but Pie charts are broken without this PR, so it would be awesome if you could release a patch.

[pawelfus]

Next release will be probably in August, date is not specified yet. It's a regression, so you can use either v8.1.0 or modify the source code (replace Highcharts.SVGRenderer with H.SVGRenderer).

[felipemfp]

Next release will be probably in August, date is not specified yet. It's a regression, so you can use either v8.1.0 or modify the source code (replace Highcharts.SVGRenderer with H.SVGRenderer).

v8.1.0 has a vulnerability issue, and I really didn't want to patch highcharts. We had four releases in March, 2 in June... why couldn't we get 1 in July?

[bre1470]

Hi @felipemfp!
Consider using the current nightly for development until the next release: npm install --save highcharts/highcharts-dist#nightly. See https://github.com/highcharts/highcharts-dist#install-nightly-build
The nightly will stay the same for the next two weeks because of national vacations in Norway.