New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vacation2020 #13910
vacation2020 #13910
Conversation
Visual test results - No difference foundSamples changed
|
File size comparison
|
bugfix/13914-axis-negative-log
docs/unboostable-boost-options
bugfix/10779-yAxis-max-issue
@@ -56,6 +56,19 @@ if (!Array.prototype.indexOf) { | |||
return -1; | |||
}; | |||
} | |||
if (!Array.prototype.fill) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The oldie-polyfills.js
module is intended for IE6-8. Array.prototype.fill
is not supported for IE9-11. This means IE9-11 will crash, so we need to implement it another way. @madepiet .
if (xAxisIndex === -1) { | ||
const newRow: any = new Array(event.dataRows[0].length); | ||
|
||
newRow.fill(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment about the Array.prototype.fill
polyfill.
if (!wasAdded) { | ||
const newRow: any = new Array(event.dataRows[0].length); | ||
|
||
newRow.fill(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment about the Array.prototype.fill
polyfill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this now, will create a new issue for the remaining comment.
No description provided.