Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/13780-tooltip-reversed-y #14432

Merged
merged 4 commits into from Sep 30, 2021
Merged

Conversation

khlieng
Copy link
Member

@khlieng khlieng commented Oct 27, 2020

Fixed #13780, tooltip was mispositioned when yAxis was reversed.

@khlieng khlieng added the Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. label Oct 27, 2020
@khlieng khlieng self-assigned this Oct 27, 2020
@highsoft-bot highsoft-bot added this to Pending Review in Development-Flow via automation Oct 27, 2020
@pawelfus
Copy link
Contributor

While at it, can we also fix tooltip in the non-inverted chart too? See: https://jsfiddle.net/BlackLabel/oqzvpy25/ ?

PS: Missing test ;)

Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Pawel said 👆

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Nov 2, 2020

Visual test results - Differences found

Found 11 diffing sample(s). Please review the differences.

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Nov 2, 2020

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
highcharts.js 98.0 kB
292.2 kB
98.0 kB
292.3 kB
21 B
81 B
highstock.js 130.2 kB
392.9 kB
130.2 kB
393.0 kB
12 B
81 B
highmaps.js 114.8 kB
351.4 kB
115.0 kB
351.5 kB
142 B
39 B
highcharts-gantt.js 132.6 kB
399.7 kB
132.6 kB
399.8 kB
26 B
92 B

@ds-cbo
Copy link

ds-cbo commented Sep 23, 2021

Could I bump this PR? I just came across this issue and I think it would be nice if we could at least merge this fix and keep the non-inversed fix for a later moment.

@raf18seb
Copy link
Contributor

raf18seb commented Sep 23, 2021

FYI @khlieng

@ds-cbo you can use this workaround plugin for now (until the fix is merged): https://jsfiddle.net/BlackLabel/4k2he6w1/

@khlieng
Copy link
Member Author

khlieng commented Sep 23, 2021

🙏 @TorsteinHonsi

@TorsteinHonsi TorsteinHonsi merged commit 4c4770d into master Sep 30, 2021
Development-Flow automation moved this from Review in progress to Done Sep 30, 2021
@TorsteinHonsi TorsteinHonsi deleted the bugfix/13780-tooltip-reversed-y branch September 30, 2021 07:40
@highsoft-bot highsoft-bot added this to the Next milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog.
Projects
Development

Successfully merging this pull request may close these issues.

Tooltip mispositioned when Y-axis is reversed
6 participants