Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed legend kbd issues #16520, #16545, #16467. #16736

Merged
merged 1 commit into from Dec 3, 2021
Merged

Fixed legend kbd issues #16520, #16545, #16467. #16736

merged 1 commit into from Dec 3, 2021

Conversation

oysteinmoseng
Copy link
Member

Fixed legend keyboard navigation issues #16520, #16545, #16467.

@oysteinmoseng oysteinmoseng added the Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. label Dec 1, 2021
@highsoft-bot highsoft-bot added this to Review in progress in Development-Flow via automation Dec 1, 2021
This was linked to issues Dec 1, 2021
"Arrow Up" and "Arrow down" move focus out of Legend area when there is only one Legend #16520
Closed
[Accessibility] Toggle legend in pie chart using keyboard only works the first time #16545
Closed
Keyboard focus lost when using labelFormatter and accessibility #16467
Closed
@highsoft-bot
Copy link
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
modules/accessibility.js 34.1 kB
123.5 kB		 34.1 kB
123.6 kB		 11 B
136 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

TorsteinHonsi
TorsteinHonsi approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit c9e118a into master Dec 3, 2021
Development-Flow automation moved this from Review in progress to Done Dec 3, 2021
@TorsteinHonsi TorsteinHonsi deleted the bugfix/legend-kbd-nav-issues branch December 3, 2021 12:53
@highsoft-bot highsoft-bot added this to the Next milestone Dec 3, 2021
@oysteinmoseng oysteinmoseng mentioned this pull request Dec 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog.
Projects
Development-Flow
  
Done
Milestone
v10.0.0
3 participants
@oysteinmoseng @highsoft-bot @TorsteinHonsi